fix(tui): prevent spinner garbage in non-TTY environments#29601
Open
imtiazNDMA wants to merge 1 commit into
Open
fix(tui): prevent spinner garbage in non-TTY environments#29601imtiazNDMA wants to merge 1 commit into
imtiazNDMA wants to merge 1 commit into
Conversation
The plugin install spinner from @clack/prompts outputs ANSI escape sequences unconditionally. When stdout is not a TTY (CI, subprocess, piped output), \r and CSI sequences appear as garbage. Added a TTY-aware spinner wrapper that falls back to plain console.log/console.error when stdout is not a terminal. Fixes anomalyco#27908
github-actions
Bot
added
the
needs:compliance
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Found potential related PRs:
Both of these PRs appear to be addressing the same issue: preventing spinner garbage output when stdout is not a TTY. They may already be closed or merged, but you should check if PR #29601 is actually a duplicate or if it's solving a remaining edge case that wasn't fully addressed by the previous attempts. |
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #27908
Type of change
What does this PR do?
The plugin install spinner from @clack/prompts outputs ANSI escape sequences unconditionally. When stdout is not a TTY (CI, subprocess, piped output), carriage return and CSI sequences appear as garbage text.
Added a TTY-aware spinner wrapper that falls back to plain console.log/console.error when stdout is not a terminal.
How did you verify your code works?
Checklist